Add sanitisation for org and project names

This commit is contained in:
rtm516 2020-05-28 19:35:29 +01:00
parent 15dec56422
commit b1c187ec44

View File

@ -7,6 +7,7 @@ import requests
import json import json
import dateutil.parser import dateutil.parser
import datetime import datetime
import re
import gitlab # pip install python-gitlab import gitlab # pip install python-gitlab
import gitlab.v4.objects import gitlab.v4.objects
@ -374,7 +375,7 @@ def _import_project_issues(gitea_api: pygitea, issues: [gitlab.v4.objects.Projec
def _import_project_repo(gitea_api: pygitea, project: gitlab.v4.objects.Project): def _import_project_repo(gitea_api: pygitea, project: gitlab.v4.objects.Project):
if not repo_exists(gitea_api, project.namespace['name'], project.name): if not repo_exists(gitea_api, project.namespace['name'], name_clean(project.name)):
clone_url = project.http_url_to_repo clone_url = project.http_url_to_repo
if GITLAB_ADMIN_PASS is '' and GITLAB_ADMIN_USER is '': if GITLAB_ADMIN_PASS is '' and GITLAB_ADMIN_USER is '':
clone_url = project.ssh_url_to_repo clone_url = project.ssh_url_to_repo
@ -390,21 +391,21 @@ def _import_project_repo(gitea_api: pygitea, project: gitlab.v4.objects.Project)
"description": project.description, "description": project.description,
"mirror": False, "mirror": False,
"private": private, "private": private,
"repo_name": project.name, "repo_name": name_clean(project.name),
"uid": owner['id'] "uid": owner['id']
}) })
if import_response.ok: if import_response.ok:
print_info("Project " + project.name + " imported!") print_info("Project " + name_clean(project.name) + " imported!")
else: else:
print_error("Project " + project.name + " import failed: " + import_response.text) print_error("Project " + name_clean(project.name) + " import failed: " + import_response.text)
else: else:
print_error("Failed to load project owner for project " + project.name) print_error("Failed to load project owner for project " + name_clean(project.name))
def _import_project_repo_collaborators(gitea_api: pygitea, collaborators: [gitlab.v4.objects.ProjectMember], project: gitlab.v4.objects.Project): def _import_project_repo_collaborators(gitea_api: pygitea, collaborators: [gitlab.v4.objects.ProjectMember], project: gitlab.v4.objects.Project):
for collaborator in collaborators: for collaborator in collaborators:
if not collaborator_exists(gitea_api, project.namespace['name'], project.name, collaborator.username): if not collaborator_exists(gitea_api, project.namespace['name'], name_clean(project.name), collaborator.username):
permission = "read" permission = "read"
if collaborator.access_level == 10: # guest access if collaborator.access_level == 10: # guest access
@ -421,7 +422,7 @@ def _import_project_repo_collaborators(gitea_api: pygitea, collaborators: [gitla
else: else:
print_warning("Unsupported access level " + str(collaborator.access_level) + ", setting permissions to 'read'!") print_warning("Unsupported access level " + str(collaborator.access_level) + ", setting permissions to 'read'!")
import_response: requests.Response = gitea_api.put("/repos/" + project.namespace['name'] +"/" + project.name + "/collaborators/" + collaborator.username, json={ import_response: requests.Response = gitea_api.put("/repos/" + project.namespace['name'] +"/" + name_clean(project.name) + "/collaborators/" + collaborator.username, json={
"permission": permission "permission": permission
}) })
if import_response.ok: if import_response.ok:
@ -475,21 +476,21 @@ def _import_groups(gitea_api: pygitea, groups: [gitlab.v4.objects.Group]):
for group in groups: for group in groups:
members: [gitlab.v4.objects.GroupMember] = group.members.list(all=True) members: [gitlab.v4.objects.GroupMember] = group.members.list(all=True)
print("Importing group " + group.name + "...") print("Importing group " + name_clean(group.name) + "...")
print("Found " + str(len(members)) + " gitlab members for group " + group.name) print("Found " + str(len(members)) + " gitlab members for group " + name_clean(group.name))
if not organization_exists(gitea_api, group.name): if not organization_exists(gitea_api, name_clean(group.name)):
import_response: requests.Response = gitea_api.post("/orgs", json={ import_response: requests.Response = gitea_api.post("/orgs", json={
"description": group.description, "description": group.description,
"full_name": group.full_name, "full_name": group.full_name,
"location": "", "location": "",
"username": group.name, "username": name_clean(group.name),
"website": "" "website": ""
}) })
if import_response.ok: if import_response.ok:
print_info("Group " + group.name + " imported!") print_info("Group " + name_clean(group.name) + " imported!")
else: else:
print_error("Group " + group.name + " import failed: " + import_response.text) print_error("Group " + name_clean(group.name) + " import failed: " + import_response.text)
# import group members # import group members
_import_group_members(gitea_api, members, group) _import_group_members(gitea_api, members, group)
@ -497,7 +498,7 @@ def _import_groups(gitea_api: pygitea, groups: [gitlab.v4.objects.Group]):
def _import_group_members(gitea_api: pygitea, members: [gitlab.v4.objects.GroupMember], group: gitlab.v4.objects.Group): def _import_group_members(gitea_api: pygitea, members: [gitlab.v4.objects.GroupMember], group: gitlab.v4.objects.Group):
# TODO: create teams based on gitlab permissions (access_level of group member) # TODO: create teams based on gitlab permissions (access_level of group member)
existing_teams = get_teams(gitea_api, group.name) existing_teams = get_teams(gitea_api, name_clean(group.name))
if existing_teams: if existing_teams:
first_team = existing_teams[0] first_team = existing_teams[0]
print("Organization teams fetched, importing users to first team: " + first_team['name']) print("Organization teams fetched, importing users to first team: " + first_team['name'])
@ -507,11 +508,11 @@ def _import_group_members(gitea_api: pygitea, members: [gitlab.v4.objects.GroupM
if not member_exists(gitea_api, member.username, first_team['id']): if not member_exists(gitea_api, member.username, first_team['id']):
import_response: requests.Response = gitea_api.put("/teams/" + str(first_team['id']) + "/members/" + member.username) import_response: requests.Response = gitea_api.put("/teams/" + str(first_team['id']) + "/members/" + member.username)
if import_response.ok: if import_response.ok:
print_info("Member " + member.username + " added to group " + group.name + "!") print_info("Member " + member.username + " added to group " + name_clean(group.name) + "!")
else: else:
print_error("Failed to add member " + member.username + " to group " + group.name + "!") print_error("Failed to add member " + member.username + " to group " + name_clean(group.name) + "!")
else: else:
print_error("Failed to import members to group " + group.name + ": no teams found!") print_error("Failed to import members to group " + name_clean(group.name) + ": no teams found!")
# #
@ -545,11 +546,11 @@ def import_projects(gitlab_api: gitlab.Gitlab, gitea_api: pygitea):
milestones: [gitlab.v4.objects.ProjectMilestone] = project.milestones.list(all=True) milestones: [gitlab.v4.objects.ProjectMilestone] = project.milestones.list(all=True)
issues: [gitlab.v4.objects.ProjectIssue] = project.issues.list(all=True) issues: [gitlab.v4.objects.ProjectIssue] = project.issues.list(all=True)
print("Importing project " + project.name + " from owner " + project.namespace['name']) print("Importing project " + name_clean(project.name) + " from owner " + project.namespace['name'])
print("Found " + str(len(collaborators)) + " collaborators for project " + project.name) print("Found " + str(len(collaborators)) + " collaborators for project " + name_clean(project.name))
print("Found " + str(len(labels)) + " labels for project " + project.name) print("Found " + str(len(labels)) + " labels for project " + name_clean(project.name))
print("Found " + str(len(milestones)) + " milestones for project " + project.name) print("Found " + str(len(milestones)) + " milestones for project " + name_clean(project.name))
print("Found " + str(len(issues)) + " issues for project " + project.name) print("Found " + str(len(issues)) + " issues for project " + name_clean(project.name))
# import project repo # import project repo
_import_project_repo(gitea_api, project) _import_project_repo(gitea_api, project)
@ -558,13 +559,13 @@ def import_projects(gitlab_api: gitlab.Gitlab, gitea_api: pygitea):
_import_project_repo_collaborators(gitea_api, collaborators, project) _import_project_repo_collaborators(gitea_api, collaborators, project)
# import labels # import labels
_import_project_labels(gitea_api, labels, project.namespace['name'], project.name) _import_project_labels(gitea_api, labels, project.namespace['name'], name_clean(project.name))
# import milestones # import milestones
_import_project_milestones(gitea_api, milestones, project.namespace['name'], project.name) _import_project_milestones(gitea_api, milestones, project.namespace['name'], name_clean(project.name))
# import issues # import issues
_import_project_issues(gitea_api, issues, project.namespace['name'], project.name) _import_project_issues(gitea_api, issues, project.namespace['name'], name_clean(project.name))
# #
@ -610,5 +611,15 @@ def print_error(message):
print_color(bcolors.FAIL, message) print_color(bcolors.FAIL, message)
def name_clean(name):
newName = name.replace(" ", "_")
newName = re.sub(r"[^a-zA-Z0-9_]", "-", newName)
if (newName.lower() == "plugins"):
return newName + "-user"
return newName
if __name__ == "__main__": if __name__ == "__main__":
main() main()